I'm always distracted by the huge number of (inactive) pools filling my
screen when I do "systat pool". So the diff below change the behavior
of this view to only show statistics of ``active'' pools by default, the
current behavior can be restored by pressing 'A'.
Anybody else find this useful? ok?
Index: pool.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/systat/pool.c,v
retrieving revision 1.7
diff -u -p -r1.7 pool.c
--- pool.c 2 Jul 2014 00:12:34 -0000 1.7
+++ pool.c 12 Aug 2014 09:05:41 -0000
@@ -30,6 +30,7 @@ int read_pool(void);
void sort_pool(void);
int select_pool(void);
void showpool(int k);
+int pool_keyboard_callback(int);
/* qsort callbacks */
int sort_name_callback(const void *s1, const void *s2);
@@ -43,6 +44,7 @@ struct pool_info {
};
+int print_all = 0;
int num_pools = 0;
struct pool_info *pools = NULL;
@@ -94,7 +96,7 @@ order_type pool_order_list[] = {
/* Define view managers */
struct view_manager pool_mgr = {
"Pool", select_pool, read_pool, sort_pool, print_header,
- print_pool, keyboard_callback, pool_order_list, pool_order_list
+ print_pool, pool_keyboard_callback, pool_order_list, pool_order_list
};
field_view views_pool[] = {
@@ -257,14 +259,21 @@ read_pool(void)
void
print_pool(void)
{
+ struct pool_info *p;
int i, n, count = 0;
if (pools == NULL)
return;
for (n = i = 0; i < num_pools; i++) {
- if (pools[i].name[0] == 0)
+ p = &pools[i];
+ if (p->name[0] == 0)
continue;
+
+ if (!print_all &&
+ (p->pool.pr_nget == 0 && p->pool.pr_npagealloc == 0))
+ continue;
+
if (n++ < dispstart)
continue;
showpool(i);
@@ -316,4 +325,18 @@ showpool(int k)
print_fld_size(FLD_POOL_IDLE, p->pool.pr_nidle);
end_line();
+}
+
+int
+pool_keyboard_callback(int ch)
+{
+ switch (ch) {
+ case 'A':
+ print_all ^= 1;
+ gotsig_alarm = 1;
+ default:
+ return keyboard_callback(ch);
+ };
+
+ return (1);
}
Index: systat.1
===================================================================
RCS file: /home/ncvs/src/usr.bin/systat/systat.1,v
retrieving revision 1.97
diff -u -p -r1.97 systat.1
--- systat.1 1 Nov 2013 10:40:15 -0000 1.97
+++ systat.1 12 Aug 2014 09:05:41 -0000
@@ -375,6 +375,10 @@ Available orderings are:
.Ic size ,
and
.Ic number of pages .
+.Pp
+By default only the statistics of active pools are displayed but pressing
+.Ic A
+changes the view to show all of them.
.It Ic queues
Display statistics about the active queues,
similar to the output of
