On Fri, Jun 06, 2014 at 10:11:57AM +0200, Otto Moerbeek wrote:
> On Thu, Jun 05, 2014 at 09:41:03AM -0600, Theo de Raadt wrote:
>
> > > The new malloc has been comitted, so now take the next step.
> > >
> > > This changes _dl_malloc to a regular non-zeroing _dl_malloc and uses
> > > _dl_calloc and _dl_reallocarray.
> > >
> > > This needs carefull review.
> >
> > Yes very careful.
> >
> > Otto is basing this part off ugly ld.so refactoring tree I shared with
> > him. It took me many days to get it working the first time.. Please
> > check carefully.
> >
> > In summary: current ld.so malloc() has an implicit bzero. This is moving
> > us to no implicit bzero, the callee has to that work. Just like the
> > intrinsic behaviours of the libc variants.
> >
> > At the same time, the more sophisticated calloc() and reallocarray()
> > versions are added...
>
> New version, in the sense that is has a real _dl_reallocarray and _dl_realloc.
>
> The actual _dl_realloc path is not used atm, so no functional change.
> Old tests and reviews remain valid.
This is now about a week old and has been in snaps for a while. I did
not receive many test or review reports. I want to move forward with
this (i have more changes queued in mind), so please spend some time
with this diff.
-Otto
