Martin Pieuchot <[email protected]> writes:

> Hello Florian,
>
> On 26/04/14(Sat) 22:22, Florian Riehm wrote:
>> On 04/26/14 20:35, Alexander Bluhm wrote:
>> > 
>> >>         /*
>> >>          * To avoid byte-swapping the same value over and over again.
>> >>          */
>> > 
>> > FreeBSD has code matching this comment.  In OpenBSD the code is
>> > gone and so should the comment.  Of course that is unrelated to
>> > this diff.
>> > 
>> 
>> I have removed the comment in my new diff also.
>> 
>> [...]
>
> Be careful next time you send a diff, this one got reformatted and I
> couldn't apply it correctly ;)
>
> Here's an updated version of your diff that adds a check in case
> m_get() returns NULL (very unlikely) and since I couldn't easily
> understand the two fields set to 0x00, I decided to document them.
>
> ok?

Compile-tested only but makes sense to me.

I would have called panic() instead of printf(), but *shrug*.

[...]

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to