On Sun, May 4, 2014 at 12:21 AM, patrick keshishian <[email protected]>wrote:
> On Sun, May 04, 2014 at 02:38:40AM -0400, Jean-Philippe Ouellet wrote:
>
...
> > - if ((irow = (char **)malloc(sizeof(char *) *
> > - (DB_NUMBER + 1))) == NULL) {
> > + irow = reallocarray(NULL, DB_NUMBER + 1, sizeof(char *));
>
> why not use calloc(2)?
>
Please justify your belief that the existing code is wrong by lack of
memset/bzero. Please do so for *ALL* the places where you suggested using
calloc() where Jean-Philippe Ouellet's patch suggest reallocarray().
Either:
a) the existing code's lack of memset/bzero is a bug (details?), OR
b) using calloc() instead of reallocarray() is *wrong*.
Philip Guenther
