The patch removes the unreasonable use of blank lines. If its automatically generated then the patch is useless.
About the choices of the software, yes $HOME/.xinitrc is used IF it exists. Shouldnt then be the right choice to let the user choose its apps? IMHO fvwm and xterm are quite arbitrary. --- HLG -------- Mensaje original -------- De: Stuart Henderson Fecha:26/04/2014 06:38 (GMT-03:00) A: Héctor Luis Gimbatti CC: [email protected] Asunto: Re: patch /etc/X11/xinit/xinitrc On 2014/04/26 04:33, Héctor Luis Gimbatti wrote: > I submit two patches for the file /etc/X11/xinit/xinitrc: These diffs are unreadable (generally, use "diff -up" for sending diffs, and include them inline) .. but based on the descriptions: > 1. patch.p1 it removes extra blank lines in the file. The file is generated from /usr/xenocara/app/xinit/xinitrc.cpp; this is standard cpp(1) behaviour. It could be changed by unifdef'ing in the source file, but it is more sane to use the file direct from upstream's xinit source tree. > 2. patch.p2 it removes fvwm and xterm references since there is no reason why > the user should choose such applications. /etc/X11/xinit/xinitrc isn't about user choice, it is to provide sane working defaults using programs from a standard OpenBSD installation. OK so we could change it to cwm or twm and uxterm, but there would be complaints about that too. User choice would go in ~/.xinitrc.
