On Fri, Dec 06, 2013 at 08:59:56PM -0500, Brad Smith wrote:
> On 28/11/13 10:05 PM, Brad Smith wrote:
> >Remove unsigned comparison < 0.
> >
> >../../../../compat/linux/linux_misc.c:1531:24: error: comparison of unsigned
> >expression < 0 is always false [-Werror,-Wtautological-compare]
> >
> >Comments? OK?
>
> ping.
Okay pirofti@
>
> >Index: linux_misc.c
> >===================================================================
> >RCS file: /home/cvs/src/sys/compat/linux/linux_misc.c,v
> >retrieving revision 1.83
> >diff -u -p -r1.83 linux_misc.c
> >--- linux_misc.c 25 Oct 2013 05:10:03 -0000 1.83
> >+++ linux_misc.c 29 Nov 2013 02:32:48 -0000
> >@@ -1657,7 +1657,7 @@ linux_sys_prctl(struct proc *p, void *v,
> >
> > switch (SCARG(uap, option)) {
> > case LINUX_PR_SET_PDEATHSIG:
> >- if (SCARG(uap, arg2) < 0 || SCARG(uap, arg2) >= LINUX__NSIG)
> >+ if (SCARG(uap, arg2) >= LINUX__NSIG)
> > return (EINVAL);
> > ed->pdeath_signal = SCARG(uap, arg2);
> > break;
> >
>
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
