The sc_model field is currently set to an unsigned int type but the Sound
Blaster code expects a signed type since it sets the model to SB_UNK which
as can be seen from the diff below has a value of -1.
../../../../dev/isa/sb.c:307:8: error: comparison of 0 <= unsigned expression
is always true [-Werror,-Wtautological-compare]
OK?
Index: sbdspvar.h
===================================================================
RCS file: /home/cvs/src/sys/dev/isa/sbdspvar.h,v
retrieving revision 1.16
diff -u -p -r1.16 sbdspvar.h
--- sbdspvar.h 14 Mar 2002 03:16:05 -0000 1.16
+++ sbdspvar.h 29 Nov 2013 02:45:11 -0000
@@ -162,7 +162,7 @@ struct sbdsp_softc {
#define SBM_CT1745 4
#define ISSBM1745(x) ((x)->sc_mixer_model >= SBM_CT1XX5)
- u_int sc_model; /* DSP model */
+ int sc_model; /* DSP model */
#define SB_UNK -1
#define SB_1 0 /* original SB */
#define SB_20 1 /* SB 2 */
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
