On Fri, Apr 5, 2013 at 3:26 PM, Ted Unangst <[email protected]> wrote:
> Index: sys/sysctl.h
> ===================================================================
> RCS file: /cvs/src/sys/sys/sysctl.h,v
> retrieving revision 1.131
> diff -u -p -r1.131 sysctl.h
> --- sys/sysctl.h 24 Mar 2013 00:09:31 -0000 1.131
> +++ sys/sysctl.h 5 Apr 2013 22:18:44 -0000
> @@ -174,7 +174,6 @@ struct ctlname {
> #define KERN_CPTIME2 71 /* array: cp_time2 */
> #define KERN_CACHEPCT 72 /* buffer cache % of physmem
> */
> #define KERN_FILE2 73 /* struct: file entries */
> -#define KERN_RTHREADS 74 /* kernel rthreads support
> enabled */
> #define KERN_CONSDEV 75 /* dev_t: console terminal
> device */
> #define KERN_NETLIVELOCKS 76 /* int: number of network
> livelocks */
> #define KERN_POOL_DEBUG 77 /* int: enable pool_debug */
Maybe leave a comment that 74 was KERN_RTHREADS like for KERN_PROC?
> @@ -256,7 +255,7 @@ struct ctlname {
> { "cp_time2", CTLTYPE_STRUCT }, \
> { "bufcachepercent", CTLTYPE_INT }, \
> { "file2", CTLTYPE_STRUCT }, \
> - { "rthreads", CTLTYPE_INT }, \
> + { "rthreads", 0 }, \
> { "consdev", CTLTYPE_STRUCT }, \
> { "netlivelocks", CTLTYPE_INT }, \
> { "pool_debug", CTLTYPE_INT }, \
Maybe change "rthreads" to "gap" like the other removed sysctl entries?
Otherwise seems ok to me.
