On Tue, Mar 26, 2013 at 07:31:01AM -0500, Vladimir Támara Patiño wrote: > I didnt' receive answer if I should send both patches as one. Since > I corrected a realloc in collate.c, here I'm sending everything > (including man pages of wcscoll, wcsxfrm and corrections > for strcoll and strxfmr).
I don't have much time right now to read this in detail and try it out. But I've skimmed it once more and wanted to give you some feedback. The style of the lex/yacc stuff in colldef looks good to me now. It seems you have an outdated version of colldef.h in this diff, e.g. the STR_LEN define is back. I doubt this diff compiles as-is. It seems there is some compat stuff in collate.c, at least that what this constant seems to be used for: > +#define COLLATE_VERSION "1.1\n" Is this really needed? Can we remove this, or is your diff adding colldef files which use the 1.1 format? wcscoll.c has indentation issues (not very important but it would be good to make this code KNF, see the style(9) man page). There are several C++ comments in this patch (// foo), please change them to /* foo */ or remove them if not strictly necessary. As discussed before, comments like this one aren't necessary: /** In OpenBSD using wchar_t, while the original from FreeBSD was char * */ I'd remove any references to xlocale from this diff. It really doesn't matter right now, this diff should focus on collations support only. For instance, I'd rename the struct xlocale_collate to something like struct __collate.
