On Tue, Mar 19, 2013 at 14:24, Martin Pieuchot wrote:
> On 15/03/13(Fri) 16:59, Ted Unangst wrote:
>> Replace LIST_END with NULL, for clarity and less characters.
>>
>> frag6.c was definitely a big fan of LIST_END.
> 
> Careful, I had to edit your diff to be able to apply it correctly.
> 
> I'm mostly ok with your diff, but in some place I think that it would be
> better to change the whole for() loop by a LIST_FOREACH{,_SAFE}() instead
> of only replacing the LIST_END, see below.

The only reason I haven't done that is I want the diff to be very easy
to verify. It does exactly one thing. But I agree using the foreach
macros would also be an improvement.

Reply via email to