Hi,

In if_trunk.c there's an explicit if_down() for trunk ports being
removed from the trunk. This seems unnecessary to me and is there since
the trunk feature has initially added to OpenBSD.

Greetings,
Matthias

===================================================================

diff --git a/sys/net/if_trunk.c b/sys/net/if_trunk.c
index 5ceb6cb..0b64dd8 100644
--- a/sys/net/if_trunk.c
+++ b/sys/net/if_trunk.c
@@ -410,10 +410,6 @@ trunk_port_destroy(struct trunk_port *tp)
        /* Remove multicast addresses from this port */
        trunk_ether_cmdmulti(tp, SIOCDELMULTI);

-       /* Port has to be down */
-       if (ifp->if_flags & IFF_UP)
-               if_down(ifp);
-
        ifpromisc(ifp, 0);

        /* Restore interface */
-- 
1.7.9.5

Reply via email to