[PATCH] remove duplicate NULL check in if_ppp.c

[Michael W. Bombardieri]

Hi Tech,

I have a small ppp diff...

At the top of function ppp_ccp() we check
m->m_len against PPP_HDRLEN. After accessing
m_next we return if the new mp value is NULL.
Immediately after that, we check mp for NULL
again.

The following patch removes the duplicate check.
Does this look OK?

- Michael


Index: if_ppp.c
===================================================================
RCS file: /cvs/src/sys/net/if_ppp.c,v
retrieving revision 1.65
diff -u -r1.65 if_ppp.c
--- if_ppp.c    28 Mar 2012 19:39:33 -0000      1.65
+++ if_ppp.c    11 Oct 2012 14:33:41 -0000
@@ -1136,7 +1136,7 @@
        mp = m->m_next;
        if (mp == NULL)
            return;
-       dp = (mp != NULL)? mtod(mp, u_char *): NULL;
+       dp = mtod(mp, u_char *);
     } else {
        mp = m;
        dp = mtod(mp, u_char *) + PPP_HDRLEN;