On Tue, Jun 14, 2011 at 11:38:45AM +0200, Javier Vazquez wrote:
> Hello Everybody,
> 
>       I installed OpenBSD 4.9 current in my old Toshiba M30. Although,
>       there was not LCD brightness control, so I started to do something 
> about 
>       it, taking into account the Toshiba acpi support of FreeBSD.
>       http://fxr.watson.org/fxr/source/dev/acpi_support/acpi_toshiba.c
> 
>       Successfully, I can manage the LCD brightness level using wsconsctl(8).
> 
>       wsconsctl display.brightness=100. ;) works nicely by command
>       line as well by setting the brightness level in /etc/wsconsctl.conf 
> file.
> 
>       I attached the required patch files for testing. I hope can be
>       useful for other guys using toshiba laptops as I added the
>       Libretto and Dynabook models.
> 
>       Thanks to Paul for coaching me to provide a decent patch :).

You should have done:

$ cd /sys/dev/acpi
$ cvs add acpitoshiba.c
$ cd /sys
$ cvs diff -uNp <files>

So that you can supply one easy patch for people to test.

Also, the comment about the && instead of || is correct.

People with Toshiba's should test this and report back if this works for
them or not.

The 'WARN: not a buffer' AML message is a known issue and jordan@ is
looking into it.

Reply via email to