On Sun, Jun 05, 2011 at 08:45:33AM +0100, Jason McIntyre wrote: > On Sat, Jun 04, 2011 at 10:19:49PM -0400, Lawrence Teo wrote: > > isakmpd(8)'s -L command-line option enables IKE packet capture. It is > > documented on the isakmpd(8) man page as follows: > > > > -L Enable IKE packet capture. When this option is given, isakmpd > > will capture to file an unencrypted copy of the negotiation > > packets it is sending and receiving. This file can later be read > > by tcpdump(8) and other utilities using pcap(3). > > > > The documentation is currently not clear exactly which file isakmpd > > will use to log the packet captures. The correct file *is* listed in > > the FILES section (it is /var/run/isakmpd.pcap); however, I think it > > would be helpful to mention that file in the description of -L itself, > > so that the reader would not have to hunt for it throughout the entire > > man page. > > > > Similarly, the "p on/off" FIFO commands to enable IKE packet capture > > are documented as follows: > > > > p on[=<path>] > > p off Enable or disable cleartext IKE packet capture. > > When enabling, optionally specify which file isakmpd should > > capture the packets to. > > > > Again, the default file is not mentioned. What is also not documented > > is, if an alternate file is specified via "p on=/path/to/altfile", its > > path must begin with /var/run (I found out the hard way :)). > > > > The following diff improves the documentation by specifying the default > > packet capture file in the text for -L itself, and also documents the > > restriction about the alternate file path for the "p on" FIFO command > > (borrowing some text from the -l option). > > > > Any thoughts or comments? > > > > Lawrence > > > > how very trendy to have two options do the same thing (-L/-l). note also > the irony in being able to issue a "p off" to isakmpd. > > anyway, i'd like to offer the following tweaked version of your diff. > it's a little simpler.
Jason, Thank you for your feedback. I think your tweak looks great, where it definitely makes the text simpler and more readable. Thanks, Lawrence
