On Tue, Apr 05, 2011 at 06:19:32PM +0200, Henning Brauer wrote: > so i wanna change the world order a bit again. > basically, no part of the tree should bother with setting tcp and udp > checksums. when they are needed, the stack just sets these flags, and > ip_output / ip6_output do the checksum then. we're not too far off for > ipv4, as usual ipv6 has it all wrong. > most parts of the stack dealing with udp and tcp don't seperate v4/v6, > and having gazillions of > if (af == AF_INET) > m->m_flags |= M_TCPV4_CSUM_OUT; > else > m->m_flags |= M_TCPV6_CSUM_OUT; > is stupid. ip_output and ip6_output do have an idea wether they deal > with v4 or v6... (despite the fact that you could just do the > conditional on af there if really needed) > > so here we go. ok?
Seems reasonable to me, not being a netinet[6] habitue. ok krw@ for what that is worth. .... Ken
