On 01/09/2010, at 7:30 PM, Mark Kettenis wrote:
> I realise you committed this already, but can you elaborate on those
> XXX's in there?
these two?
+ if (bq->bufq_outstanding == 0 /* XXX and quiesced */)
+ SLIST_FOREACH(bq, &bufqs, bufq_entries) { /* XXX */
the first one refers to the fact that we call wakeup when we run out of io on
the device, as opposed to when we run out of io on the device when we're
waiting for the device to quiesce.
the second is there cos the SLIST is handled without taking the global
bufqs_mtx, which every other user of the SLIST takes before mucking around
with it.
dlg