On Sat, Aug 21, 2010 at 05:21:20PM -0700, Matthew Dempsky wrote: > On Sat, Aug 21, 2010 at 10:04 AM, Bret S. Lambert <[email protected]> > wrote: > > This diff changes the locking in sbt and sdmmc from the old-and-busted > > lockmgr locks to the new-hotness rwlock locks. I don't have the > > hardware to test this on, so anybody with sbt/sdmmc is encouraged > > to give it a spin. > > Why not simply change the SDMMC_LOCK/SDMMC_UNLOCK/SDMMC_ASSERT_LOCKED > macros and leave the .c files untouched (other than the lock init)?
A version that did that was offered, but I was convinced off-list that my original desire to not obfuscate the locking was correct. > > Also, I'd prefer rw_exit_write() be used instead of rw_exit() when you > know you're holding a write lock. As I believe you said before. My bikeshed, therefore it will be banana-shaped.
