On Thu, May 6, 2010 at 4:42 AM, Thomas Pfaff <tpf...@tp76.info> wrote: > Sometimes I'm reading code from the source tree and then stumble upon > various things that I'm wondering if it's worth "fixing". These are > not real bugs, which is the numero uno priority, but I'm wondering if > anyone care about these things or if they're just an annoyance and a > waste of time for the committers. > > Following is a list of those things and a yes or no answer should be > sufficient: > > * Remove useless cast operations, e.g. p = malloc((size_t)sizeof(n)); > * Make pre-ANSI function definitions ANSI. > * Add missing function prototypes (mostly together with the above). > * Typos and grammatical errors in comments. > * Wrap long lines to 80 characters. > * First character lowercase in "usage" strings. > * Anything else that I have forgotten about.
Sometimes such changes constitute real improvement, but usually not. If there's some other idiom you can clean up (malloc/memset -> calloc, inline tolower, variables named aa, bb, cc, ...), or maybe a lint or -Wall warning or two, wrap it up with the rest of a cleanup. But be careful with the lint warnings. It's going to be noisy and you can't fix them all.
