> Date: Sat, 8 Oct 2022 10:58:58 -0500 > From: Mario Campos <mario.andres.cam...@gmail.com> > > I ran a SAST tool, CodeQL, against trunk and found a couple of > instances (below) where the 16-bit integer `i` is compared to the > 32-bit integer `max_rx_queues` or `max_tx_queues` in ixg(4). If > `max_rx_queues` (or `max_tx_queues`) is sufficiently large, it could > lead to an infinite loop. > > sys/dev/pci/ixgbe/ixgbe_vf.c:280 > sys/dev/pci/ixgbe/ixgbe_vf.c:284 > sys/dev/pci/ixgbe/ixgbe_common.c:1158 > sys/dev/pci/ixgbe/ixgbe_common.c:1162
Cool. I don't think this case is a bug because the quantities in question are bounded by IXGBE_VF_MAX_TX/RX_QUEUES, which are both 8. But it would be reasonable to use u32 or even just unsigned for this. Did this tool turn anything else up?
