On Mon, Oct 28, 2019 at 01:04:13PM -0700, Jason Thorpe wrote:
>
> > On Oct 28, 2019, at 12:03 PM, Michael van Elst <mlel...@serpens.de> wrote:
> >
> > So anything smaller as DEV_BSIZE will already fail at some other place,
> > validating it in bounds_check_with_label might even be the best place
> > for now, independent on wether it triggers a division by zero. Better
> > places could exist when all drivers would use common code, there are
> > still exceptions. Then you could validate the value once, and not
> > for every disk access.
>
> Note that some (all? I forget...) HP-IB CS/80 drives use 256-byte sectors.
Try to build a system with DEV_BSIZE=256 (or 128 if you want to support
old 8" disks).
In theory this will work, but I'd guess that some people nowadays use
DEV_BSIZE when they want to say 512.
Greetings,
--
Michael van Elst
Internet: mlel...@serpens.de
"A potential Snark may lurk in every tree."
