On Thu, Nov 17, 2011 at 05:23:32PM +0100, Martin Husemann wrote: > On Thu, Nov 17, 2011 at 05:10:24PM +0100, Manuel Bouyer wrote: > > With the old quotactl, the kernel has no way to tell if it really got a > > string of a struct dqblk (or something else); it can just interpret the > > pointer as a string and see if it works. If instead of a string it got > > a dqblk whose first 2 entries happends to be 0x6f6f622f 0x78300074, > > you'll have troubles (you're doing quotaon on /boot). > > Yes, the old quotactl interface sucked. > Moving the command ID into the argument structure fixes it, and allows easy > versioning as well - just as a simple example for alternatives to proplib.
Yes, the old interface can be improved with an ad-hoc interface format. I still believe proplib is better. For example, you can go from a 32bit to a 64bit uid_t/gid_t without versionning (in the data structure it's still <integer></integer>). -- Manuel Bouyer <[email protected]> NetBSD: 26 ans d'experience feront toujours la difference --
