On Fri, Oct 21, 2011 at 11:57:33AM +0200, Manuel Bouyer wrote: > > > > - the type "struct ufs_quota_entry" is apparently, despite its name > > and (parts of) its usage pattern, meant to be fs-independent. > > true. More precisely it describes the traditionnal quota properties > we have seen on unix filesystems for some time (ufs is unix filesystems, > isn't it ?)
This is bound to cause tremendous confusion. Can we please change the name to "fs_quota_entry"? Consider what will happen when (or if) there is a "zfs_quota_entry" or an "lfs_quota_entry": it will look to anyone reading the code as if ufs_quota_entry is specific to the ufs layer and the filesystems that use it. Not good. David, is it the case that ufs_quota_entry as presently defined is generic enough that it can serve your needs for LFS? If not, what would have to be changed? Thor
