In article <20110716.213640.759900912627637478....@vnop.net>, UCHIYAMA Yasushi <u...@vnop.net> wrote: >I have prepared v7fs support of makefs. > >ftp://ftp.netbsd.org/pub/NetBSD/misc/uch/makefs_v7fs-110716.tar.gz > >How about? please review.
v7fs.c:
don't check for NULL before calling free.
option_t should be made to static const (and other fs's)
fs_specific is void *, so it does not need a cast.
I don't think that the Calculated size should go to stderr.
The rest looks fine.
christos
