On Fri, Apr 08, 2011 at 07:28:06PM +0000, Eduardo Horvath wrote: > On Fri, 8 Apr 2011, David Young wrote: > > > On Fri, Apr 08, 2011 at 08:47:59PM +0200, Matthias Drochner wrote: > > > > > > [email protected] said: > > > > If the flag isn't set, the driver has no business setting it. Also, > > > > if the flag isn't set, there's not much use in the driver setting the > > > > corresponding bit in the PCI CSR. > > > > > > I don't think this goes into the right direction. The driver shouldn't > > > have a business setting flags in the attach args, except in rare, > > > mostly historical cases like indirect configuration. > > > > The patch stops drivers from setting flags in the attach args, which I > > think that you will agree is a step in the right direction. > > I disagree on both counts. All this patch does is fix a couple of buggy > drivers and create a ton of unnecessary code churn.
I was not clear. By "stops," I did not mean "prevents." I meant "stops *particular* drivers". The meaning of the new flags is actually different from the old, so I think that it makes sense to use new names. Getting rid of the old names will poison code that misuses them. Dave -- David Young OJC Technologies [email protected] Urbana, IL * (217) 344-0444 x24
