Thank you for the patch. I'll make sure this gets applied to the next release.
- Jesse On 2/25/19 1:00 PM, sysvinit-devel-requ...@nongnu.org wrote: > Send Sysvinit-devel mailing list submissions to > sysvinit-devel@nongnu.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.nongnu.org/mailman/listinfo/sysvinit-devel > or, via email, send a message with subject or body 'help' to > sysvinit-devel-requ...@nongnu.org > > You can reach the person managing the list at > sysvinit-devel-ow...@nongnu.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Sysvinit-devel digest..." > > > Today's Topics: > > 1. New stable packages available (Jesse Smith) > 2. [PATCH] sysvinit/man/*: Fix some warnings from "groff" > (Bjarni Ingi Gislason) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Sun, 24 Feb 2019 20:18:33 -0400 > From: Jesse Smith <jsm...@resonatingmedia.com> > To: sysvinit-devel@nongnu.org > Subject: [sysvinit-devel] New stable packages available > Message-ID: <35679a50-9deb-3bfc-a098-5e2d27eeb...@resonatingmedia.com> > Content-Type: text/plain; charset=utf-8 > > I am happy to report there are new stable versions of SysV init, > startpar and insserv availale to download. This release was mostly > focused on minor bug fixes, cleaning up some code and fixing a few > documentation bugs. The only changes that happened between the beta and > the final release were for fixing a typo in the fstab-decode manual page > and avoiding multiple re-builds of insserv on Debian's build system. > > There are a couple of significant changes which I feel are worth noting, > maybe with a WARNING, about the new behaviour: > > 1. I have imported the logsave program from e2fsprogs, This is the same > program as was available in the latest stable e2fsprogs release and it > does the same thing. The reason for the duplication is some downstream > scripts use the logsave program, but it is not available unless the > e2fsprogs package is installed. Since initscripts relies on logsave, I > imported it. (Not sure yet if it'll be dropped from e2fsprogs in the > future.) This means our version of logsave will overwrite any existing > one on the system, unless it is patched out of the Makefile. This should > have no practical effect as it is the same program, but worth noting > there is a potential over-write happening. > > 2. The halt command now passes "-h -P" to the shutdown command if "halt > -p" or "poweroff" is called on the command line. This causes shutdown to > set the INIT_HALT environment variable to "POWEROFF". This value is > often checked by shutdown scripts. And, in some cases, this may cause > shutdown behaviour to change when the "halt" or "poweroff" command is > used. In the past, calling halt did not set INIT_HALT and the system was > more likely to simply halt without powering off too. > > That is it for major changes. The rest is minor bug fixes, some code > clean-up and performance improvements. Detailed changelogs follow. > > The new packages can be downloaded from here: > http://download.savannah.nongnu.org/releases/sysvinit/ > > Please file bug reports here: > https://savannah.nongnu.org/bugs/?group=sysvinit > > The change logs for the three packages are shown below: > > > SysV init 2.94 > =============== > > ??? * When the halt command is called with the -p flag (or as poweroff) > ????? the command now passes the "-h -P" flags to shutdown. This > ????? in turn sets the INIT_HALT environment variable to POWEROFF. > ????? Assuming this value is checked by initscripts during the > ????? shutting down procedure, it should cause the system to > ????? be powered off. > ????? If halt is called without -p then the value of INIT_HALT > ????? is not set and the default action (often set in /etc/defaut/halt) > ????? is taken. > ??? * Removed unnecessary malloc.h includes. Memory allocation > ????? and freeing is now handled in stdlib.h > ??? * Added defines for FreeBSD to make some components compile > ????? on FreeBSD 11. > ??? * Increased the size of the kernel command line buffer in bootlogd > ????? from 256 characters to 4096. This size is defined in > KERNEL_COMMAND_LENGTH > ????? for easy modification downstream. > ??? * Added logsave.c and logsave.8 manual page from e2fsprogs to make > ????? sure logsave is available to initscripts. > ??? * Updated src/Makefile to make sure bootlogd compiles with Clang. > ??? * Use defined constants for password length in sulogin. Makes > ????? it easier to update/patch later. > ??? * Minor code fixes across multiple source files to avoid buffer > ????? overflows, or uninitialized strings. > ??? * Changed the way the "when" variable is used internally in shutdown.c. > ????? It starts as a NULL pointer, then might get set as a pointer to > optarg, > ????? then it might get set to point to an argv parameter, then it might > have > ????? a string value copied into it, over-writing the original data. We > should > ????? not risk over-writing internal variables which might get used for > something > ????? else (it's rude and security risk). Set up "when" as its own buffer > ????? that has data from optargs and/or argv copied into it. > ??? * Fixed typo in init.8 manual page. > ??? * Updated text of fstab-decode to explain what the utility does. > ?? ? > > insserv 1.19.0 > ================ > > - Applied distro-independent patches from Debian to > ? upstream code and manual page. > ? Mostly introduces typo fixes and more flexible > ? Makefile options. > ? The following patches are no longer needed downstream: > ? 20_manpage_spelling > ? 21_tweak_warnings > ? 30_interactive_regexp_match > ? 92_m68k_alignment > ? 100_show > ? 130_crossbuild_fixes > ? 150_core_string_test > ? 160_manual_page_update > ? 170_undeclared_extension > ? 180_maxsymlinks > > - Minor update to manual page to fix typo. > - Added patch from Dmitry Bogatov which makes communicating > ? with D-bus optional at compile time. This feature is > ? enabled by compiling with WANT_SYSTEMD defined. > - Migrated Debian testsuite into the "tests" directory. > - Fixed typo in warning messages. > - Cause Makefile to create link needed for testing in "tests" > ? directory when building insserv. Running distclean removes > ? link to avoid cluttering archive. > - Fixed pushd() and popd() functions to avoid terminating insserv > ? if the current working directory is inaccessible. > ? Fixes Debian bugs #573571 and #785687. > - Updated warning message insserv disables when an init.d script > ? is not executable, to better indicate the script will not > ? be enabled at boot/entering runlevel. > ? Closes Debian bug 661314. > - Applied patch from Bloeslaw Tokarski which should improve > ? performance of insserv in some cases by bypassing unnecessary > ? some fadvise calls. > ? Closes Debian bug #775912 > - Updated manual page with format changes. Applied > ? patch from Bjarni Ingi Gislason which closes Debian > ? bug #919610 > - Applied two new memory checks to avoid potential segfault. > - Print full path names when giving status updates on creating > ? (or failing to create) files such as .depend.boot, .depend.start > ? and .depend.stop. > ? Addresses Debian bug #547609 > - Minor fix to Makefile to make sure it cleans up after > ? creating tarball. > - Added patch to make automated builds not require re-building source > ? on Debian. (Patch provided by Helmut.) > ? Closes Debian bug #922870 > > ? > startpar 0.62 > ============== > > * Fixed typos in startpar.c error messages. > ? Moves Debian patch 99 upstream. > * Applied Debian patches 81_timeout and 83_hardening upstream. > * Minor code clean-up in makeboot.c to remove duplicate > ? instructions. > * Added changelog to the tarball. > > > > > ------------------------------ > > Message: 2 > Date: Sat, 16 Feb 2019 01:00:01 +0000 > From: Bjarni Ingi Gislason <bjarn...@rhi.hi.is> > To: sysvinit-devel@nongnu.org > Subject: [sysvinit-devel] [PATCH] sysvinit/man/*: Fix some warnings > from "groff" > Message-ID: <20190216010001.ga30...@rhi.hi.is> > Content-Type: text/plain; charset=us-ascii > > Use a single-font-style macro (".B", ".I") for a single argument. > > Fix other warnings from groff (developmental version) > > Output is from: test-groff -b -e -mandoc -T utf8 -rF0 -t -w w -z > > #### > > <init.8>:254 (macro BI): only 1 argument, but more are expected > troff: <init.8>:279: warning: can't find font '\' > <init.8>:347 (macro BR): only 1 argument, but more are expected > > #### > > an-old.tmac: <initctl.5>:119 (.RE): warning: extra .RE or .RS is missing > before it; "an-RS-open" is 0. > > an-old.tmac: <initctl.5>:143 (.RE): warning: extra .RE or .RS is missing > before it; "an-RS-open" is 0. > > #### > > an-old.tmac: <initscript.5>:65 (.RE): warning: extra .RE or .RS is missing > before it; "an-RS-open" is 0. > > #### > > <killall5.8>:23 (macro RB): only 1 argument, but more are expected > <killall5.8>:25 (macro IR): only 1 argument, but more are expected > > #### > > <last.1>:31 (macro RB): only 1 argument, but more are expected > <last.1>:33 (macro RB): only 1 argument, but more are expected > <last.1>:34 (macro RB): only 1 argument, but more are expected > <last.1>:41 (macro RB): only 1 argument, but more are expected > <last.1>:42 (macro RB): only 1 argument, but more are expected > > #### > > <mountpoint.1>:28 (macro RB): only 1 argument, but more are expected > > #### > > <readbootlog.1>:30 (macro RB): only 1 argument, but more are expected > > #### > > <wall.1>:53: backtrace > .../tmac/an-old.tmac:503: backtrace: macro 'IP' > troff: <wall.1>:53: warning: can't find font 'n' > > Signed-off-by: Bjarni Ingi Gislason <bjarn...@rhi.hi.is> > --- > man/init.8 | 6 +++--- > man/initctl.5 | 2 -- > man/initscript.5 | 1 - > man/killall5.8 | 6 +++--- > man/last.1 | 10 +++++----- > man/mountpoint.1 | 2 +- > man/readbootlog.1 | 2 +- > man/wall.1 | 2 +- > 8 files changed, 14 insertions(+), 17 deletions(-) > > diff --git a/man/init.8 b/man/init.8 > index cbfbf07..b158371 100644 > --- a/man/init.8 > +++ b/man/init.8 > @@ -251,7 +251,7 @@ can then manipulate the command line so that \fBps\fP(1) > shows > the current runlevel. > .PP > .TP 0.5i > -.BI "--version " > +.B \-\-version > This argument, when used on its own, displays the current version of init > to the console/stdout. It is a quick way to determine which init software and > version is being used. After the version information is displayed, init > @@ -276,7 +276,7 @@ On receipt of this signals, init closes and re-opens its > control fifo, > .TP 0.5i > .B SIGUSR2 > When init receives SIGUSR2, init closes and leaves the control fifo, > -\fB/run/initctl\f\P, closed. This may be used to make sure init is not > +\fB/run/initctl\fP, closed. This may be used to make sure init is not > holding open any files. However, it also prevents init from switching > runlevels. Which means commands like shutdown no longer work. > The fifo can be re-opened by sending init the SIGUSR1 signal. > @@ -344,7 +344,7 @@ page by Michael Haardt > (u31b...@pool.informatik.rwth-aachen.de). > .BR login (1), > .BR sh (1), > .BR runlevel (8), > -.BR shutdown(8), > +.BR shutdown (8), > .BR kill (1), > .BR initctl (5), > .BR inittab (5), > diff --git a/man/initctl.5 b/man/initctl.5 > index f736c23..5985df9 100644 > --- a/man/initctl.5 > +++ b/man/initctl.5 > @@ -116,7 +116,6 @@ if ((fd = open(INIT_FIFO, O_WRONLY)) >= 0) /* open pipe > for writing */ > .fi > > .sp > -.RE > .SH NOTES > Usually the /run/initctl pipe would only be used by low-level programs to > request a power-related shutdown or change the runlevel, like telinit > @@ -140,7 +139,6 @@ the SIGUSR1 signal. > If the /run/initctl pipe is closed then it may still be possible to bring > down the system using the shutdown command's -n flag, but this is not > always clean and not recommended. > -.RE > .SH FILES > /run/initctl > /sbin/init > diff --git a/man/initscript.5 b/man/initscript.5 > index 875879c..a20a88f 100644 > --- a/man/initscript.5 > +++ b/man/initscript.5 > @@ -62,7 +62,6 @@ This script is not meant as startup script for daemons or > somesuch. > It has nothing to do with a \fIrc.local\fP style script. It's just > a handler for things executed from \fB/etc/inittab\fP. Experimenting > with this can make your system un(re)bootable. > -.RE > .SH FILES > /etc/inittab, > /etc/initscript. > diff --git a/man/killall5.8 b/man/killall5.8 > index ac3cc09..29b53f1 100644 > --- a/man/killall5.8 > +++ b/man/killall5.8 > @@ -20,11 +20,11 @@ > killall5 -- send a signal to all processes. > .SH SYNOPSIS > .B killall5 > -.RB -signalnumber > +.B \-signalnumber > .RB [ \-o > -.IR omitpid[,omitpid...]] > +.IR omitpid [, omitpid ...]] > .RB [ \-o > -.IR omitpid[,omitpid...]... ] > +.IR omitpid [, omitpid ...]...] > .SH DESCRIPTION > .B killall5 > is the SystemV killall command. It sends a signal to all processes except > diff --git a/man/last.1 b/man/last.1 > index c57743c..c886b93 100644 > --- a/man/last.1 > +++ b/man/last.1 > @@ -28,18 +28,18 @@ last, lastb \- show listing of last logged in users > .B last > .RB [ \-R ] > .RB [ \-\fInum\fP ] > -.RB "[ \-\fBn\fP \fInum\fP ]" > +[\-\fBn\fP \fInum\/\fP] > .RB [ \-adFiowx ] > -.RB "[ \-\fBf\fP \fIfile\fP ]" > -.RB "[ \-\fBt\fP \fIYYYYMMDDHHMMSS\fP ]" > +[\-\fBf\fP \fIfile\/\fP] > +[\-\fBt\fP \fIYYYYMMDDHHMMSS\/\fP] > .RI [ name... ] > .RI [ tty... ] > .br > .B lastb > .RB [ \-R ] > .RB [ \-\fInum\fP ] > -.RB "[ \-\fBn\fP \fInum\fP ]" > -.RB "[ \-\fBf\fP \fIfile\fP ]" > +[\-\fBn\fP \fInum\/\fP] > +[\-\fBf\fP \fIfile\/\fP] > .RB [ \-adFiowx ] > .RI [ name... ] > .RI [ tty... ] > diff --git a/man/mountpoint.1 b/man/mountpoint.1 > index 992c9f5..7b4e4ab 100644 > --- a/man/mountpoint.1 > +++ b/man/mountpoint.1 > @@ -25,7 +25,7 @@ mountpoint \- see if a directory is a mountpoint > .I /path/to/directory > .br > .B /bin/mountpoint > -.RB \-x > +.B \-x > .I /dev/device > .SH DESCRIPTION > \fBMountpoint\fP checks if the directory is a mountpoint. > diff --git a/man/readbootlog.1 b/man/readbootlog.1 > index c95369b..fc8844c 100644 > --- a/man/readbootlog.1 > +++ b/man/readbootlog.1 > @@ -27,7 +27,7 @@ readbootlog \- show contents of the boot log, stripping > away control characters > .SH SYNOPSIS > .B readbootlog > .RB [ \-h ] > -.RB "[ \-\fBf\fP \fIfile\fP ]" > +[\-\fBf\fP \fIfile\/\fP] > .br > .\"}}} > .\"{{{ Description > diff --git a/man/wall.1 b/man/wall.1 > index 2fe8301..df37d73 100644 > --- a/man/wall.1 > +++ b/man/wall.1 > @@ -50,7 +50,7 @@ and level > .BR LOG_INFO . > > .SH OPTIONS > -.IP \fB\-n\fn > +.IP \fB\-n\fP > Suppresses the normal banner printed by > .IR wall , > changing it to "Remote broadcast message".
