On Mon, 02.02.15 23:25, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote:
> On Mon, Feb 02, 2015 at 09:36:15PM +0100, Lennart Poettering wrote: > > On Mon, 02.02.15 21:21, Lennart Poettering ([email protected]) wrote: > > > > I now fixed all but the DECIMAL_STR_MAX() + 1 issue now... > > > > Was too lazy for DECIMAL_STR_MAX() thing... > Hm, I'm not sure if we want DECIMAL_STR_MAX to include the space for > the null. Sometimes there's more than one decimal in a format. > Also, even if there's just one, but not at the end, it somehow feels > awkward to have the extra byte "allocated" in the middle of the string. Yeah, I figure it would make sense to remove the +1 for the NUL byte from the macro. If you want to fix this, go ahead, but of course this would mean checking all current uses of that macro to see if it needs an extra +1 then... Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
