On 07/12/2013 08:36 PM, Lennart Poettering wrote:
On Tue, 09.07.13 21:15, Jan Janssen (medhe...@web.de) wrote:+ if (*key_file) { + r = read_one_line_file(*key_file, &passphrase); + if (r < 0) { + log_error("Failed to read key file: %s", strerror(-r)); + *key_file = NULL; + return -EAGAIN;I can't say I like functions that change the parameters when they fail, any chance we can fix that? otherwise looks good. Lennart
When I read the (old) luks code correctly, it does the same: falling back to normal password query if the key file does not work. I just thought it would be best to do the same here. I can certainly make this a fatal error, so no retries are attempted, but then the luks code should do the same, imho. What do you think? Jan _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
