I had also tried a different approach i.e more general for handling modular equations locally. That was facing some issue. I will also be making a PR to get more of your suggestions. More tests I will be adding to it.
On Wed, Mar 20, 2019 at 6:17 PM Yathartha Joshi <[email protected]> wrote: > Yeah, you can but if you wish to use the code written by someone else, > then you should cherry-pick the commits and then continue your work. In > this way the authorship is maintained. > > Cheers! > Yathartha Joshi > > On Wednesday, March 20, 2019 at 4:29:47 PM UTC+5:30, Kunal Sharma wrote: >> >> I was trying to implement modular equations in solveset, issue #13178 >> <https://github.com/sympy/sympy/issues/13178>. Looking at the PR #14284 >> <https://github.com/sympy/sympy/pull/14284>, most of the work has >> already been done by @ishanaj, but it looks like that the work has stalled. >> I would like to help in merging the PR. So should I just make a new PR with >> imrovements that are asked by @normalhuman >> > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/ea674097-1584-450d-a501-e963bb0ae80b%40googlegroups.com > <https://groups.google.com/d/msgid/sympy/ea674097-1584-450d-a501-e963bb0ae80b%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAGPLj20O79MbowgcbF1GEwNUtRxL37S1_ne8Vu_e8GFXvFvSHg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
