Troy, On Sun, Dec 23, 2012 at 10:39 PM, Troy A. Griffitts <scr...@crosswire.org> wrote: > Dear Greg, > > Looking to apply this SFTP patch, could you give me some background as to > why the check to ignore across all transports for '.' and '..'?
Our downloading method runs recursively from the given directory until it runs out of directory depth. FTP servers don't usually seem to return . and .. as valid paths, and the HTTP(S) transport attempts to parse the returned HTML page to avoid the link to the parent directory. But whatever options are passed by cURL to the SFTP transport resulted in it returning . and .. as paths within the current directory. Because '.' came first in the list, the installmgr was running through an infinite loop whenever it tried to pull data from the server. I added it at the level of all transports because we don't want to either loop infinitely on '.' or accidentally pull a whole server recursively by following '..' to the root of the server. It might be a server config option that permits it, but I wanted to avoid the possibility of the InlstallMgr class getting choked up on it. --Greg > > Thanks, > > Troy > > > > > On 12/03/2012 04:06 PM, Greg Hellings wrote: > > The attached patch will introduce support for SFTPSource transports in > the SWORD engine, allowing a user to access remote repositories over > SFTP (which is enabled by default when a user enables SSH). > > --Greg > > > > _______________________________________________ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page > > > > _______________________________________________ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page _______________________________________________ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
