Backwards compatibility maybe?
--
There are 10 types of people in this world. Those who understand binary and
those who do not.
---
David McClellan
On Jun 28, 2011 6:38 PM, "Greg Hellings" <greg.helli...@gmail.com> wrote:
> I'm curious as to why you opted to make another new filter set that
> was a copy of one, rather than just fixing the old one. What does
> keeping htmlhref the way it is gain?
>
> --Greg
>
> On Tuesday, June 28, 2011, Troy A. Griffitts <scr...@crosswire.org> wrote:
>> As discussed, I've added a new Render filter set: FMT_XHTML
>>
>> As usual, if you create your SWMgr asking for this Render output, you
>> will get the new markup:
>>
>> SWMgr library(new MarkupFilterMgr(FMT_XHTML));
>>
>> SWModule *kjv = library.getModule("KJV");
>>
>> kjv->setText("jn.3.16");
>> cout << kjv->RenderText();
>>
>> but now you can also ask for any header information which might be
>> available and useful:
>>
>> cout << kjv->getRenderHeader();
>>
>>
>>
>> examples/cmdline/lookup now will print any header information if it is
>> available.
>>
>>
>> The FMT_WEBIF filter set is now based on the FMT_XHTML filters, so any
>> changes to the XHTML filters will also affect the WEBIF format.
>>
>>
>> I have only made very small changes to the FMT_XHTML filters after
>> copying them from the FMT_HTMLHREF filter set. It should be safe to
>> switch your render output to the new FMT_XHTML if you are currently
>> using the FMT_HTMLHREF render output. The small changes should only
>> involve divineName, words of Christ, and title, if I remember correctly.
>> I believe title has changed to <h3>, word of Christ is <span
>> class="wordsOfJesus">, and divineName is <span class="divineName">.
>>
>>
>> If you want the default styles, use the new getRenderHeader() method
>> which will give you basic styles for these classes. Then override them
>> if you wish.
>>
>>
>> Feel free to suggest classed XHTML markup for the rest of the untouched
>> tags or if you have access, update them yourself, but please be
>> considerate and try to supply a style in the header which keeps the
>> current rendering.
>>
>>
>> Peter, the WEBIF format is a subclass of the most recent HTML output
>> filters with slight overrides for rendering notes and word as javascript
>> clickable areas used in SWORDWEB (or any other Web Interface which wants
>> to use them).
>>
>>
>> We have now officially broken binary compatibility with 1.6. If we need
>> to make a bugfix release to 1.6.2 then we will need to branch trunk.
>>
>>
>>
>> Hope this is goes somewhere,
>>
>>
>> Troy
>>
>>
>>
>>
>>
>>
>>
>> On 28/06/11 09:23, Peter von Kaehne wrote:
>>> On Mon, 2011-06-27 at 12:26 +0200, Troy A. Griffitts wrote:
>>>> As DM has suggested, I am all in favor of copying the current osis to
>>>> htmlhref filter (or actually copying and merging in the changes from
>>>> webif filter) to osisxhtml
>>>
>>> What is the webif filter about? I see it is has been there a while, but
>>> I have not really checked it out prior today. It clearly is similar to
>>> osishtmlhref.
>>>
>>>> and slowing changing markup to use classed
>>>> spans and providing a SWBuf OSISXHTML::getHeader(); method which would
>>>> supply a basic header to prepend to a display object when rendering.
>>>
>>> Sounds good.
>>>
>>> Peter
>>>
>>>
>>> _______________________________________________
>>> sword-devel mailing list: sword-devel@crosswire.org
>>> http://www.crosswire.org/mailman/listinfo/sword-devel
>>> Instructions to unsubscribe/change your settings at above page
>>
>> _______________________________________________
>> sword-devel mailing list: sword-devel@crosswire.org
>> http://www.crosswire.org/mailman/listinfo/sword-devel
>> Instructions to unsubscribe/change your settings at above page
>>
>
> _______________________________________________
> sword-devel mailing list: sword-devel@crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page
