So are we good on the _ICUSWORD_ --with-icusword option? To answer the how curiosity question below, configure.ac has these pertinent lines:
if test x$with_icusword = xyes; then AM_CXXFLAGS="$AM_CXXFLAGS -D_ICUSWORD_" AM_CFLAGS="$AM_CFLAGS -D_ICUSWORD_" fi AM_CONDITIONAL(HAVE_ICUSWORD, test x$with_icusword = xyes) Not sure if HAVE_ICUSWORD is useful anywhere in the lower autoconf files anywhere (it's still used in src/modules/filters/Makefile.am but not sure if it needs to be), but for consistency, it's defined in case anyone needs it. Troy On Thu, 2009-12-03 at 21:07 -0500, Matthew Talbert wrote: > > How's this? I just committed code which adds a --with-icusword option > > to configure. This advertises the feature to developers and replaces > > the previous behavior of defining _ICUSWORD_ > > This is excellent. Previously the only way to actually define it was > to pass it as a compiler flag, eg export CXXFLAGS="-D_ICUSWORD_", > which meant that it really was only getting used in Visual Studio > until I came along. This is a much better option. > > I'll be testing this in the coming days on Mingw so I will let you > know if there are problems on Mingw. > > Just out of curiosity, how does HAVE_ICUSWORD get transformed into > _ICUSWORD_ (as the latter is what is in the *.cpp files)? > > Matthew > > _______________________________________________ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page _______________________________________________ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
