Troy, Excuse the late hour - I thought you mean the changes I had in my patchset for the the filters in the library. I should have remembered... they weren't even part of the patch Jonathan used, seeing as they were incorporated into the engine some time ago.
Since it's past 3 AM for me and I have a pressing coding issue for my last class project (ever?), I can't look at what you're talking about now. I'll give it a gander sometime in the next few days. --Greg On Wed, Apr 29, 2009 at 2:58 AM, Troy A. Griffitts <scr...@crosswire.org> wrote: > Dear Greg, > > I don't understand :) > > Looking at the current SVN code, there are no strip filters at all (and I > can't think of any reason there should be-- but maybe I'm overlooking > something). > > There is one filter in there, but all uses of it are commented out, so I > believe someone was just using it for debugging. > > Actually, I just ran SVN's mod2osis on KJV and got valid XML output. And > validating it against the 2.1.1 OSIS schema doesn't seem much different to > what Jonathan reported after applying your patch. > > So here's my thought: Are you SURE no one has applied your patch logic in > the past (maybe not in mod2osis, but pushed down into a filter or two)? > > I'd like to get your work added if it hasn't yet been. Let me know. > > -Troy. > > > > Greg Hellings wrote: >> >> On Wed, Apr 29, 2009 at 2:32 AM, Troy A. Griffitts <scr...@crosswire.org> >> wrote: >>> >>> OK, looked at the patch. Not sure what the strip filters are being added >>> for. Any comments? >> >> My only comment is that the seem to already have been applied some >> time ago. I had put them in there so that all the strip filters were >> consistent in their output. They used to have [ on some and ( on >> others. >> >> --Greg >> >>> Jonathan Marsden wrote: >>>> >>>> Greg Hellings wrote: >>>> >>>>> I have some patches on >>>>> crosswire.org/~ghellings that used to apply back in about r2150 range. >>>> >>>> OK, I just grabbed it and beat it into submission a little... now it >>>> applies to svn head :) New version is at >>>> >>>> http://computeroptions.net/sword/mod2osis-new.diff >>>> >>>> Now to test it and see what it actually does! If it works, or even is >>>> "just" a significant improvement, then we can perhaps persuade Troy to >>>> apply it before rolling out RC3 :) >>>> >>>> Jonathan >>>> >>>> _______________________________________________ >>>> sword-devel mailing list: sword-devel@crosswire.org >>>> http://www.crosswire.org/mailman/listinfo/sword-devel >>>> Instructions to unsubscribe/change your settings at above page >>> >>> _______________________________________________ >>> sword-devel mailing list: sword-devel@crosswire.org >>> http://www.crosswire.org/mailman/listinfo/sword-devel >>> Instructions to unsubscribe/change your settings at above page >>> >> >> _______________________________________________ >> sword-devel mailing list: sword-devel@crosswire.org >> http://www.crosswire.org/mailman/listinfo/sword-devel >> Instructions to unsubscribe/change your settings at above page > > > _______________________________________________ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page > _______________________________________________ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
