> > Ok, there is now a check to be sure buf ends in '/' before skipping the
> > '/' at the beginning of the image url.
>
> Won't compile on ym box :)
yeah, I caught it also, after I already commited it. Please try again.
> > Not arguing the merits of this naming scheme (it's too late to change
> > this now), it seems that the byproduct of the current bug isn't so bad a
> > solutions. This currently allows you to keep strongshebrew images in a
> > directory: .../strongs/strongshebrew/images, and greek in a similar
> > structure. Let me know..
>
> I think we should have one way to store images for all module types. It will
> confuse module creators if some types of modules need the images in another
> subdir of DataPath.
> In the case of Strongs the modules should give urls like <img
> src="/strongshebrew/image.jpg"> and <img src="/strongsgreek/image.jpg">. I
> think this solution is better - all modules use the same way.
I think I agree with you in priciple, but not with your conclusion. I
also agree that module authors should use the same syntax for all
modules. I believe that syntax should be something like <img
src="/pic.jpg"> or optionally <img src="/images/pic.jpg">. I think your
point about not confusing module authors is valid and this is why I
think the url for images needs to be standard between Bibles,
commentaries, dictionaries, genbooks, etc.
If we change the filter to strip the basename from the url on lex/dict
and genbooks, then for these modules, the module authors will have to
add an extra directory to the url. As it stands now, the extra
directory is already added for them for these 3 cases. Does this make
sense? Still hoping to hear what you think. As said before, I think we
agree in principle, now just have to work out the details.
-Troy.
