Oh.. I did not. It was for another PR. False alarm. This PR fixes the problem: https://github.com/apple/swift/pull/9560
> On May 12, 2017, at 5:47 PM, Luke Larson <llar...@apple.com> wrote: > > Where did you run the compatibility suite on the pull request? > > Luke > >> On May 12, 2017, at 5:46 PM, Luke Larson <llar...@apple.com >> <mailto:llar...@apple.com>> wrote: >> >> It’s the same test suite. >> >> Luke >> >>> On May 12, 2017, at 5:34 PM, Max Moiseev <mois...@apple.com >>> <mailto:mois...@apple.com>> wrote: >>> >>> Missing String.init?(_:String) in an expression: >>> >>> String.init(value)! >>> >>> where value is of type String. >>> >>> Due to my changes that passed the PR compatibility testing… >>> Luke, isn’t it the same test suite? >>> >>> Max >>> >>>> On May 12, 2017, at 5:17 PM, no-re...@swift.org >>>> <mailto:no-re...@swift.org> wrote: >>>> >>>> [FAILURE] swift-master-source-compat-suite [#283] >>>> >>>> Build URL: https://ci.swift.org/job/swift-master-source-compat-suite/283/ >>>> <https://ci.swift.org/job/swift-master-source-compat-suite/283/> >>>> Project: swift-master-source-compat-suite >>>> Date of build: Fri, 12 May 2017 15:45:48 -0700 >>>> Build duration: 1 hr 31 min >>>> >>>> Changes >>>> >>>> Commit 4e9851b032b1ae351bb80854fcdb7fc943a90cad by Joe Groff: >>>> Don't classify bridging casts as WillSucceed if the object-to-value cast >>>> >>>> add: test/SILOptimizer/cast_folding_objc_bridging_conditional.sil >>>> edit: lib/Sema/TypeCheckType.cpp >>>> edit: lib/SILOptimizer/Utils/Local.cpp >>>> edit: lib/Sema/TypeCheckConstraints.cpp >>>> edit: lib/Sema/CSSimplify.cpp >>>> edit: lib/Sema/TypeChecker.h >>>> edit: include/swift/AST/ASTContext.h >>>> edit: lib/AST/ASTContext.cpp >>>> edit: lib/SIL/DynamicCasts.cpp >>>> >>>> Commit 46415e7dbd55b43d6655dd6f88a9c6ce4445b5e0 by Max Moiseev: >>>> [stdlib] Removing a String.init?(_: String), non-failable is enough >>>> >>>> edit: stdlib/public/core/String.swift >>>> >>>> Commit 9a9d1393208fbd581b49d9e855e4288e748abcfa by github: >>>> [ClangImporter] Import Swift 3 and 4 names for enumerators. (#9523) >>>> >>>> edit: lib/ClangImporter/ImportName.cpp >>>> edit: lib/ClangImporter/SwiftLookupTable.h >>>> edit: lib/ClangImporter/ImportDecl.cpp >>>> edit: test/APINotes/versioned.swift >>>> edit: lib/ClangImporter/ImportName.h >>>> edit: >>>> test/APINotes/Inputs/custom-frameworks/APINotesFrameworkTest.framework/Headers/APINotesFrameworkTest.h >>>> edit: >>>> test/APINotes/Inputs/custom-frameworks/APINotesFrameworkTest.framework/Headers/APINotesFrameworkTest.apinotes >>>> add: >>>> test/APINotes/Inputs/custom-frameworks/APINotesFrameworkTest.framework/Headers/Enums.h >>> >> >
_______________________________________________ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev
