Thanks! > On Apr 6, 2017, at 3:32 PM, Jordan Rose <jordan_r...@apple.com> wrote: > > Erik may have beat you to it. https://github.com/apple/swift/pull/8595 > <https://github.com/apple/swift/pull/8595> > > Jordan > >> On Apr 6, 2017, at 15:18, mishal_shah via swift-dev <swift-dev@swift.org >> <mailto:swift-dev@swift.org>> wrote: >> >> Looks like this was cherry-picked in swift-clang without PR testing. >> >> Thanks, >> Mishal Shah >>> On Apr 6, 2017, at 3:17 PM, Slava Pestov <spes...@apple.com >>> <mailto:spes...@apple.com>> wrote: >>> >>> I have a fix pending in this PR: https://github.com/apple/swift/pull/8594 >>> <https://github.com/apple/swift/pull/8594> >>> >>> But I’m surprised this wasn’t caught in CI. >>> >>> Slava >>> >>>> On Apr 6, 2017, at 2:58 PM, Mishal Shah <mishal_s...@apple.com >>>> <mailto:mishal_s...@apple.com>> wrote: >>>> >>>> Hi Slave, >>>> >>>> This started after following commits: >>>> >>>> https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/ >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/> >>>> Git (clang) >>>> >>>> Change -ffp-contract=fast test to run on Aarch64 (detail >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail>) >>>> Remove -ffp-contract=fast from this test (detail >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail>) >>>> Encapsulate FPOptions and use it consistently (detail >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail>) >>>> Use FPContractModeKind universally (detail >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail>) >>>> Use 'unsigned' for enum bitfields (detail >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail>) >>>> Set FMF for -ffp-contract=fast (detail >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail>) >>>> Add #pragma clang fp (detail >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail>) >>>> Fix sphinx warning from r299470 (detail >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail>) >>>> Another attempt to fix the sphinx warning from r299470 (detail >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-osx/9254/changes#detail>) >>>> >>>> Thanks, >>>> Mishal Shah >>>>> On Apr 6, 2017, at 2:53 PM, Slava Pestov via swift-dev >>>>> <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> I’m hitting this in github PR testing: >>>>> >>>>> /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/lib/ClangImporter/ImportDecl.cpp:994:34: >>>>> error: no matching constructor for initialization of >>>>> 'clang::BinaryOperator' >>>>> >>>>> auto cSetterExpr = new (Ctx) clang::BinaryOperator(cSetterMemberExpr, >>>>> ^ ~~~~~~~~~~~~~~~~~~ >>>>> /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:2929:3: >>>>> note: candidate constructor not viable: no known conversion from 'bool' >>>>> to 'clang::FPOptions' for 8th argument >>>>> BinaryOperator(Expr *lhs, Expr *rhs, Opcode opc, QualType ResTy, >>>>> ^ >>>>> /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:3085:3: >>>>> note: candidate constructor not viable: requires 9 arguments, but 8 were >>>>> provided >>>>> BinaryOperator(Expr *lhs, Expr *rhs, Opcode opc, QualType ResTy, >>>>> ^ >>>>> /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:3100:3: >>>>> note: candidate constructor not viable: requires 2 arguments, but 8 were >>>>> provided >>>>> BinaryOperator(StmtClass SC, EmptyShell Empty) >>>>> ^ >>>>> /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:2947:12: >>>>> note: candidate constructor not viable: requires single argument >>>>> 'Empty', but 8 arguments were provided >>>>> explicit BinaryOperator(EmptyShell Empty) >>>>> ^ >>>>> /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:2913:7: >>>>> note: candidate constructor (the implicit copy constructor) not viable: >>>>> requires 1 argument, but 8 were provided >>>>> class BinaryOperator : public Expr { >>>>> ^ >>>>> /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/tools/clang/include/clang/AST/Expr.h:2913:7: >>>>> note: candidate constructor (the implicit move constructor) not viable: >>>>> requires 1 argument, but 8 were provided >>>>> 1 error generated. >>>>> >>>>> Is there a Clang/LLVM merge in progress or something? >>>>> >>>>> Slava >>>>> _______________________________________________ >>>>> swift-dev mailing list >>>>> swift-dev@swift.org <mailto:swift-dev@swift.org> >>>>> https://lists.swift.org/mailman/listinfo/swift-dev >>>>> <https://lists.swift.org/mailman/listinfo/swift-dev> >>>> >>> >> >> _______________________________________________ >> swift-dev mailing list >> swift-dev@swift.org <mailto:swift-dev@swift.org> >> https://lists.swift.org/mailman/listinfo/swift-dev >
_______________________________________________ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev