Hi Tony, I like the idea that the type itself is responsible for the conversion. My own json encode/decode library worked this way and it was really great, however in trying to leverage Swift4 into it, or to replace it, I just don’t see how that’s possible given how it’s currently structured.
JSON’s types effectively end up matching specifically to primitives, of which there is no mechanism to override the behavior of how a String gets decoded for instance. The only way I can think of to accomplish that is to create *another* type, JSONString for example, but since String is a struct, I can’t subclass it, and instead need to have the real value buried inside of it … it seems to start getting messy very quickly. It also adds the obfuscation of dealing with yet another type, which I’m not against, but just feels less than ideal. Brandon Sneed From: <anthony.par...@apple.com> on behalf of Tony Parker <anthony.par...@apple.com> Date: Wednesday, August 30, 2017 at 11:30 AM To: "Sneed, Brandon" <brsn...@ebay.com> Cc: Itai Ferber <ifer...@apple.com>, "swift-corelibs-dev@swift.org" <swift-corelibs-dev@swift.org> Subject: Re: [swift-corelibs-dev] Adding type conversion capabilities to JSON encode/decode I’m still not convinced that we should actually provide such a strategy. Conversions like those below seem like the domain of each type that is being decoded. If, in a particular type, the “number” can be either a true number or a string, then that type can try decoding it as one or the other and fall back as required. That puts the responsibility of doing that kind of conversion in the type itself. JSON has very few types already. I’m not sure we want to blur the line between numbers and strings automatically… - Tony On Aug 30, 2017, at 11:24 AM, Sneed, Brandon via swift-corelibs-dev <swift-corelibs-dev@swift.org<mailto:swift-corelibs-dev@swift.org>> wrote: Hi Itai, No problem! Thanks for the heads up. Is there any way I could be involved? Happy to do the work to whatever guidance your team might have. I’m mostly just interested in it being there soon, hence volunteering. Thanks! Brandon Sneed From: <ifer...@apple.com<mailto:ifer...@apple.com>> on behalf of Itai Ferber <ifer...@apple.com<mailto:ifer...@apple.com>> Date: Wednesday, August 30, 2017 at 11:22 AM To: "Sneed, Brandon" <brsn...@ebay.com<mailto:brsn...@ebay.com>> Cc: "swift-corelibs-dev@swift.org<mailto:swift-corelibs-dev@swift.org>" <swift-corelibs-dev@swift.org<mailto:swift-corelibs-dev@swift.org>> Subject: Re: [swift-corelibs-dev] Adding type conversion capabilities to JSON encode/decode Hi Brandon, Thanks for looking at this! We’ve got plans internally to potentially add a strategy to JSONEncoder/JSONDecoder to allow lenient conversions like this — i.e. implicitly stringify numbers (or parse them from string input), among some others. This would be opt-in for consumers of JSONDecoder while not requiring any special annotations on Codable types. — Itai On 30 Aug 2017, at 10:59, Sneed, Brandon via swift-corelibs-dev wrote: Hi everyone, Just throwing this out to see if anyone else is working on this, or has opinions/suggestions on how it’s implemented. I’d like to add this to the Codable/JSONDecoder/JSONEncoder system if no one else is working on it. Type type conversion, I mean given this JSON payload: { "name": "Endeavor”, "abv": 8.9, "brewery": "Saint Arnold”, "style": "ipa" } and a struct defined as: struct Beer: Codable { let name: String let abv: String let brewery: String let style: BeerStyle } Notice that “abv” is a number in the JSON, but a String in the struct. I’d like to make it such that I can let the system know it’s ok to convert it from a number to a string as opposed to throwing an exception. The benefits are: 1. It’s defensive; service types can change without causing my application to crash. 2. It allows a developer to work with the types they want to work with as opposed to what the server provides, thus saving them time of writing a custom encode/decode code for all members. The argument against it that I’ve heard is generally “it’s a service bug, make them fix it”, which is valid but the reality is we’re not all in control of the services we injest. The same type of logic could be applied to a member name changing, though I haven’t seen this happen often in practice. I do see types in a json payload change with some frequency though. I think much of the reason stems from the fact that type conversion in javascript is effectively free, ie: you ask for a String, you get a String if possible. To implement this type conversion in practice, looking at it from the point of view using Codable/JSON(en/de)coder, one way would be to make it opt-in: struct Beer: Codable, CodingConvertible { let name: String let abv: String let brewery: String let style: BeerStyle } I like this because looking at the struct, the members still remain clear and relatively unambiguous. The downside is it’s unknown which member is likely to get converted. And since it’s opt-in, conversion doesn’t happen if the CodingConvertible conformance isn’t adhered to. Another option would be to box each type, like so: struct Beer: Codable { let name: String let abv: Convertible<String> let brewery: String let style: BeerStyle } This seems tedious for developers, but would show which types are being converted. It does however seriously weaken benefit #1 above. Those example usages above aside, I do think it’d be best if this conversion behavior was the default and no end-developer changes required. I think that could be done without impact to code that’s been already been written against the JSON en/decode bits. I’m very open to alternatives, other ideas, or anything else you might have to say on the subject. Thanks for reading! Brandon Sneed _______________________________________________ swift-corelibs-dev mailing list swift-corelibs-dev@swift.org<mailto:swift-corelibs-dev@swift.org> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.swift.org%2Fmailman%2Flistinfo%2Fswift-corelibs-dev&data=02%7C01%7Cbrsneed%40ebay.com%7C0e58a975be44418826d608d4efd427dc%7C46326bff992841a0baca17c16c94ea99%7C0%7C0%7C636397141865218008&sdata=ytYIqDtMesw4NnpUbFmiWF2%2FKfxlawG4YuVWPJd099Y%3D&reserved=0> _______________________________________________ swift-corelibs-dev mailing list swift-corelibs-dev@swift.org<mailto:swift-corelibs-dev@swift.org> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.swift.org%2Fmailman%2Flistinfo%2Fswift-corelibs-dev&data=02%7C01%7Cbrsneed%40ebay.com%7Cf2eba37a5b40474e09b108d4efd5372d%7C46326bff992841a0baca17c16c94ea99%7C0%7C0%7C636397146413883032&sdata=C1%2F8MXq%2Fh7NHgyxeKDkcHDcigtQjSztCaAeUxBzYZ3g%3D&reserved=0>
_______________________________________________ swift-corelibs-dev mailing list swift-corelibs-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
