Author: mav
Date: Tue Mar 28 10:24:01 2017
New Revision: 316089
URL: https://svnweb.freebsd.org/changeset/base/316089

Log:
  MFC r315236: Remove dangerous and questionable isp_mboxcmd_qnw() call.

Modified:
  stable/10/sys/dev/isp/isp.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/isp/isp.c
==============================================================================
--- stable/10/sys/dev/isp/isp.c Tue Mar 28 10:23:32 2017        (r316088)
+++ stable/10/sys/dev/isp/isp.c Tue Mar 28 10:24:01 2017        (r316089)
@@ -6503,20 +6503,8 @@ isp_parse_status(ispsoftc_t *isp, ispsta
 
                isp_prt(isp, ISP_LOGINFO, "port %s for target %d", reason, 
XS_TGT(xs));
 
-               /*
-                * If we're on a local loop, force a LIP (which is overkill)
-                * to force a re-login of this unit. If we're on fabric,
-                * then we'll have to log in again as a matter of course.
-                */
-               if (fcp->isp_topo == TOPO_NL_PORT ||
-                   fcp->isp_topo == TOPO_FL_PORT) {
-                       mbreg_t mbs;
-                       MBSINIT(&mbs, MBOX_INIT_LIP, MBLOGALL, 0);
-                       if (ISP_CAP_2KLOGIN(isp)) {
-                               mbs.ibits = (1 << 10);
-                       }
-                       isp_mboxcmd_qnw(isp, &mbs, 1);
-               }
+               /* XXX: Should we trigger rescan or FW announce change? */
+
                if (XS_NOERR(xs)) {
                        lp = &fcp->portdb[XS_TGT(xs)];
                        if (lp->state == FC_PORTDB_STATE_ZOMBIE) {
@@ -6664,9 +6652,8 @@ isp_parse_status_24xx(ispsoftc_t *isp, i
                isp_prt(isp, ISP_LOGINFO, "Chan %d port %s for target %d",
                    chan, reason, XS_TGT(xs));
 
-               /*
-                * There is no MBOX_INIT_LIP for the 24XX.
-                */
+               /* XXX: Should we trigger rescan or FW announce change? */
+
                if (XS_NOERR(xs)) {
                        lp = &fcp->portdb[XS_TGT(xs)];
                        if (lp->state == FC_PORTDB_STATE_ZOMBIE) {
_______________________________________________
svn-src-stable-10@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10
To unsubscribe, send any mail to "svn-src-stable-10-unsubscr...@freebsd.org"

Reply via email to