Author: arybchik Date: Fri Jan 6 07:27:40 2017 New Revision: 311492 URL: https://svnweb.freebsd.org/changeset/base/311492
Log: MFC r310750 sfxge(4): add missing barrier in common code MCDI response handling The semantics of the MCDI interfacve require reading the first dword of the header before any other data in the buffer. Add a barrier to the common code MCDI handler to enforce this. Submitted by: Andy Moreton <amoreton at solarflare.com> Sponsored by: Solarflare Communications, Inc. Modified: stable/10/sys/dev/sfxge/common/ef10_mcdi.c Directory Properties: stable/10/ (props changed) Modified: stable/10/sys/dev/sfxge/common/ef10_mcdi.c ============================================================================== --- stable/10/sys/dev/sfxge/common/ef10_mcdi.c Fri Jan 6 07:27:07 2017 (r311491) +++ stable/10/sys/dev/sfxge/common/ef10_mcdi.c Fri Jan 6 07:27:40 2017 (r311492) @@ -159,6 +159,8 @@ ef10_mcdi_poll_response( efx_dword_t hdr; EFSYS_MEM_READD(esmp, 0, &hdr); + EFSYS_MEM_READ_BARRIER(); + return (EFX_DWORD_FIELD(hdr, MCDI_HEADER_RESPONSE) ? B_TRUE : B_FALSE); } _______________________________________________ svn-src-stable-10@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10 To unsubscribe, send any mail to "svn-src-stable-10-unsubscr...@freebsd.org"