Author: truckman
Date: Fri May 20 06:33:02 2016
New Revision: 300271
URL: https://svnweb.freebsd.org/changeset/base/300271

Log:
  MFC r299580
  
  Use strlcpy() instead of strncpy() to ensure that ret->name is
  NUL terminated.  The source and destination buffers are the same
  size and the source *should* be NUL terminated, but be paranoid.
  
  Reported by:  Coverity
  CID:          1011274

Modified:
  stable/10/usr.sbin/timed/timed/master.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/usr.sbin/timed/timed/master.c
==============================================================================
--- stable/10/usr.sbin/timed/timed/master.c     Fri May 20 06:27:58 2016        
(r300270)
+++ stable/10/usr.sbin/timed/timed/master.c     Fri May 20 06:33:02 2016        
(r300271)
@@ -623,7 +623,7 @@ addmach(char *name, struct sockaddr_in *
                }
                ret->addr = *addr;
                ret->ntp = ntp;
-               (void)strncpy(ret->name, name, sizeof(ret->name));
+               (void)strlcpy(ret->name, name, sizeof(ret->name));
                ret->good = good_host_name(name);
                ret->l_fwd = &self;
                ret->l_bak = self.l_bak;
_______________________________________________
svn-src-stable-10@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10
To unsubscribe, send any mail to "svn-src-stable-10-unsubscr...@freebsd.org"

Reply via email to