Author: mav
Date: Mon Oct  5 10:50:35 2015
New Revision: 288786
URL: https://svnweb.freebsd.org/changeset/base/288786

Log:
  MFC r288067: Log iSCSI session reinstatements.
  
  False session reinstatements can be result of misconfiguration, when
  several initiators use the same initiator name and ISID.

Modified:
  stable/10/sys/cam/ctl/ctl_frontend_iscsi.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/cam/ctl/ctl_frontend_iscsi.c
==============================================================================
--- stable/10/sys/cam/ctl/ctl_frontend_iscsi.c  Mon Oct  5 10:49:47 2015        
(r288785)
+++ stable/10/sys/cam/ctl/ctl_frontend_iscsi.c  Mon Oct  5 10:50:35 2015        
(r288786)
@@ -1565,6 +1565,16 @@ restart:
                        if (cs2 != cs && cs2->cs_tasks_aborted == false &&
                            cs->cs_target == cs2->cs_target &&
                            strcmp(cs->cs_initiator_id, cs2->cs_initiator_id) 
== 0) {
+                               if (strcmp(cs->cs_initiator_addr,
+                                   cs2->cs_initiator_addr) != 0) {
+                                       CFISCSI_SESSION_WARN(cs2,
+                                           "session reinstatement from "
+                                           "different address %s",
+                                           cs->cs_initiator_addr);
+                               } else {
+                                       CFISCSI_SESSION_DEBUG(cs2,
+                                           "session reinstatement");
+                               }
                                cfiscsi_session_terminate(cs2);
                                mtx_unlock(&softc->lock);
                                pause("cfiscsi_reinstate", 1);
_______________________________________________
svn-src-stable-10@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10
To unsubscribe, send any mail to "svn-src-stable-10-unsubscr...@freebsd.org"

Reply via email to