Author: tuexen
Date: Wed Jun 17 09:44:02 2015
New Revision: 284507
URL: https://svnweb.freebsd.org/changeset/base/284507

Log:
  MFC r284393:
  Correctly detect the case where the last address is removed.

Modified:
  stable/10/sys/netinet/sctp_asconf.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/netinet/sctp_asconf.c
==============================================================================
--- stable/10/sys/netinet/sctp_asconf.c Wed Jun 17 09:41:16 2015        
(r284506)
+++ stable/10/sys/netinet/sctp_asconf.c Wed Jun 17 09:44:02 2015        
(r284507)
@@ -1328,6 +1328,7 @@ sctp_asconf_queue_add(struct sctp_tcb *s
 {
        uint32_t status;
        int pending_delete_queued = 0;
+       int last;
 
        /* see if peer supports ASCONF */
        if (stcb->asoc.asconf_supported == 0) {
@@ -1337,15 +1338,21 @@ sctp_asconf_queue_add(struct sctp_tcb *s
         * if this is deleting the last address from the assoc, mark it as
         * pending.
         */
-       if ((type == SCTP_DEL_IP_ADDRESS) && !stcb->asoc.asconf_del_pending &&
-           (sctp_local_addr_count(stcb) < 2)) {
-               /* set the pending delete info only */
-               stcb->asoc.asconf_del_pending = 1;
-               stcb->asoc.asconf_addr_del_pending = ifa;
-               atomic_add_int(&ifa->refcount, 1);
-               SCTPDBG(SCTP_DEBUG_ASCONF2,
-                   "asconf_queue_add: mark delete last address pending\n");
-               return (-1);
+       if ((type == SCTP_DEL_IP_ADDRESS) && !stcb->asoc.asconf_del_pending) {
+               if (stcb->sctp_ep->sctp_flags & SCTP_PCB_FLAGS_BOUNDALL) {
+                       last = (sctp_local_addr_count(stcb) == 0);
+               } else {
+                       last = (sctp_local_addr_count(stcb) == 1);
+               }
+               if (last) {
+                       /* set the pending delete info only */
+                       stcb->asoc.asconf_del_pending = 1;
+                       stcb->asoc.asconf_addr_del_pending = ifa;
+                       atomic_add_int(&ifa->refcount, 1);
+                       SCTPDBG(SCTP_DEBUG_ASCONF2,
+                           "asconf_queue_add: mark delete last address 
pending\n");
+                       return (-1);
+               }
        }
        /* queue an asconf parameter */
        status = sctp_asconf_queue_mgmt(stcb, ifa, type);
_______________________________________________
svn-src-stable-10@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10
To unsubscribe, send any mail to "svn-src-stable-10-unsubscr...@freebsd.org"

Reply via email to