Author: avg
Date: Mon May 25 11:33:45 2015
New Revision: 283520
URL: https://svnweb.freebsd.org/changeset/base/283520

Log:
  MFC r282473: dmu_recv_end_check: don't leak hold if 
dsl_destroy_snapshot_check_impl fails

Modified:
  stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c
==============================================================================
--- stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c Mon May 
25 11:32:10 2015        (r283519)
+++ stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c Mon May 
25 11:33:45 2015        (r283520)
@@ -2011,7 +2011,7 @@ dmu_recv_end_check(void *arg, dmu_tx_t *
                                error = dsl_dataset_hold_obj(dp, obj, FTAG,
                                    &snap);
                                if (error != 0)
-                                       return (error);
+                                       break;
                                if (snap->ds_dir != origin_head->ds_dir)
                                        error = SET_ERROR(EINVAL);
                                if (error == 0)  {
@@ -2021,7 +2021,11 @@ dmu_recv_end_check(void *arg, dmu_tx_t *
                                obj = dsl_dataset_phys(snap)->ds_prev_snap_obj;
                                dsl_dataset_rele(snap, FTAG);
                                if (error != 0)
-                                       return (error);
+                                       break;
+                       }
+                       if (error != 0) {
+                               dsl_dataset_rele(origin_head, FTAG);
+                               return (error);
                        }
                }
                error = dsl_dataset_clone_swap_check_impl(drc->drc_ds,
_______________________________________________
svn-src-stable-10@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-stable-10
To unsubscribe, send any mail to "svn-src-stable-10-unsubscr...@freebsd.org"

Reply via email to