On Wed, 29 Nov 2017, Scott Long wrote:
Log: It's time to retire AHC_REG_PRETTY_PRINT and AHD_REG_PRETTY_PRINT from the standard kernels. They are still available as custom compile options.
MI NOTES still gives MI sizes for these options. It seems unlikely that these sizes are still correct even for 1 arch where they were measured on.
Modified: head/sys/amd64/conf/GENERIC ============================================================================== --- head/sys/amd64/conf/GENERIC Wed Nov 29 23:28:40 2017 (r326376) +++ head/sys/amd64/conf/GENERIC Wed Nov 29 23:41:49 2017 (r326377) @@ -123,11 +123,7 @@ device siis # SiliconImage SiI3124/SiI3132/SiI3531 # SCSI Controllers device ahc # AHA2940 and onboard AIC7xxx devices -options AHC_REG_PRETTY_PRINT # Print register bitfields in debug - # output. Adds ~128k to driver. device ahd # AHA39320/29320 and onboard AIC79xx devices -options AHD_REG_PRETTY_PRINT # Print register bitfields in debug - # output. Adds ~215k to driver.
k is a bogus unit for memory sizes. NOTES has the same bug.
Modified: head/sys/i386/conf/GENERIC ============================================================================== --- head/sys/i386/conf/GENERIC Wed Nov 29 23:28:40 2017 (r326376) +++ head/sys/i386/conf/GENERIC Wed Nov 29 23:41:49 2017 (r326377) @@ -120,11 +120,6 @@ device siis # SiliconImage SiI3124/SiI3132/SiI3531 # SCSI Controllers device ahc # AHA2940 and onboard AIC7xxx devices -options AHC_REG_PRETTY_PRINT # Print register bitfields in debug - # output. Adds ~128k to driver. -device ahd # AHA39320/29320 and onboard AIC79xx devices -options AHD_REG_PRETTY_PRINT # Print register bitfields in debug - # output. Adds ~215k to driver. device esp # AMD Am53C974 (Tekram DC-390(T)) device hptiop # Highpoint RocketRaid 3xxx series device isp # Qlogic family
This also removes ahd. This bug is only new on i386/GENERIC. Other arches except amd64 never had ahd. arm/conf/CRB was most broken -- it had 2 PRETTY options but neither ahc or ahd. Perhaps these old drivers don't belong in any GENERIC. Bruce _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
