Author: glebius
Date: Fri Apr 14 01:56:15 2017
New Revision: 316804
URL: https://svnweb.freebsd.org/changeset/base/316804
Log:
Fix potential NULL deref.
Found by: PVS Studio
Modified:
head/sys/netpfil/pf/pf_ioctl.c
Modified: head/sys/netpfil/pf/pf_ioctl.c
==============================================================================
--- head/sys/netpfil/pf/pf_ioctl.c Fri Apr 14 00:45:09 2017
(r316803)
+++ head/sys/netpfil/pf/pf_ioctl.c Fri Apr 14 01:56:15 2017
(r316804)
@@ -2428,11 +2428,12 @@ DIOCGETSTATES_full:
#undef ERROUT
DIOCCHANGEADDR_error:
- if (newpa->kif)
- pfi_kif_unref(newpa->kif);
- PF_RULES_WUNLOCK();
- if (newpa != NULL)
+ if (newpa != NULL) {
+ if (newpa->kif)
+ pfi_kif_unref(newpa->kif);
free(newpa, M_PFRULE);
+ }
+ PF_RULES_WUNLOCK();
if (kif != NULL)
free(kif, PFI_MTYPE);
break;
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
