On Sun, 12 Feb 2017, Glen Barber wrote: [snip previous]
> > I didn't read this when I hit send on my email. Hopefully nobody takes > > offense. I was upset and still am. > > > > I still think that the revision numbers of any backout should have been > > documented in the commit log. > > > > I absolutely agree, and was the key meaning behind my "what exactly does > this mean?" reply. The commit log, as-is, provides nothing useful to > the reader. > > > Something we could do, as is expected by re@ for commits during a freeze, > > is metees also let their mentors know of what the contents of commit log > > messages will be. I think commit log messages discussing the what, why and > > rationale are as important as the code itself. > > > > I thought this was standard practice. But if not, I would agree that > both code changes and the commit log should be both approved by the > mentor. Shouldn't we then emphacise this in the Committer's Guide? -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: ma...@freebsd.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- ma...@rinet.ru *** ------------------------------------------------------------------------ _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
