On 01/09/2017 13:01, Jung-uk Kim wrote:
On 01/09/2017 12:08, John Baldwin wrote:
On Sunday, January 08, 2017 06:26:33 AM Conrad E. Meyer wrote:
Author: cem
Date: Sun Jan 8 06:26:33 2017
New Revision: 311667
URL: https://svnweb.freebsd.org/changeset/base/311667
Log:
Add some additional ACPI methods for DRM
Add AcpiGetDataFull and AcpiGetTableWithSize.
Submitted by: Matt Macy
Have these been submitted upstream? The Intel folks are generally quite
responsive on freebsd-a...@freebsd.org and this codebase is actively
maintained externally.
Please submit upstream first.
https://github.com/acpica/acpica
Since nobody responded, I just googled about it. It seems these two
functions, AcpiGetDataFull() (aka. acpi_get_data_full() in Linux) and
AcpiGetTableWithSize() (aka. acpi_get_table_with_size() in Linux), were
only added in linux-pm tree and we only need them for "Graphics" repository.
- AcpiGetDataFull()
This function is only called by acpi_get_device_data(), which is, in
turn, only called by acpi_bus_get_device() with *NULL* callback.
Therefore, I don't see any reason to pollute contrib code for this.
- AcpiGetTableWithSize()
This API is now deprecated by the upstream:
http://marc.info/?l=linux-acpi&m=148169906815835
http://marc.info/?l=linux-acpi&m=148169907615836
http://marc.info/?l=linux-acpi&m=148169908115837
http://marc.info/?l=linux-acpi&m=148169908615838
http://marc.info/?l=linux-acpi&m=148169909215840
The code changes were committed to both ACPICA:
https://github.com/acpica/acpica/commit/cac67909
and committed to linux-pm tree:
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit?id=6b11d1d677132816252004426ef220ccd3c92d2f
This means it will be removed from future Linux kernel. Therefore, we
should NOT implement the deprecated API.
Please back out r311667 and r311843 and let me know if you need any help
in resolving this matter.
Jung-uk Kim
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
