Author: ngie
Date: Thu Jan 5 08:49:06 2017
New Revision: 311390
URL: https://svnweb.freebsd.org/changeset/base/311390
Log:
snmp_table_fetch_async: don't leak `work` if snmp_pdu_send(..) fails
MFC after: 1 week
Reported by: Coverity
CID: 1017276
Modified:
head/contrib/bsnmp/lib/snmpclient.c
Modified: head/contrib/bsnmp/lib/snmpclient.c
==============================================================================
--- head/contrib/bsnmp/lib/snmpclient.c Thu Jan 5 08:42:58 2017
(r311389)
+++ head/contrib/bsnmp/lib/snmpclient.c Thu Jan 5 08:49:06 2017
(r311390)
@@ -728,8 +728,11 @@ snmp_table_fetch_async(const struct snmp
work->last_change = 0;
table_init_pdu(descr, &work->pdu);
- if (snmp_pdu_send(&work->pdu, table_cb, work) == -1)
+ if (snmp_pdu_send(&work->pdu, table_cb, work) == -1) {
+ free(work);
+ work = NULL;
return (-1);
+ }
return (0);
}
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
