Author: arybchik
Date: Wed Dec 28 11:11:15 2016
New Revision: 310692
URL: https://svnweb.freebsd.org/changeset/base/310692
Log:
sfxge(4): enclose macro complex value in parenthesis
Found by DPDK checkpatches.sh
Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days
Modified:
head/sys/dev/sfxge/common/efx_bootcfg.c
head/sys/dev/sfxge/common/efx_types.h
head/sys/dev/sfxge/common/mcdi_mon.c
Modified: head/sys/dev/sfxge/common/efx_bootcfg.c
==============================================================================
--- head/sys/dev/sfxge/common/efx_bootcfg.c Wed Dec 28 11:09:45 2016
(r310691)
+++ head/sys/dev/sfxge/common/efx_bootcfg.c Wed Dec 28 11:11:15 2016
(r310692)
@@ -43,8 +43,8 @@ __FBSDID("$FreeBSD$");
*/
#define BOOTCFG_MAX_SIZE 0x1000
-#define DHCP_END (uint8_t)0xff
-#define DHCP_PAD (uint8_t)0
+#define DHCP_END ((uint8_t)0xff)
+#define DHCP_PAD ((uint8_t)0)
static __checkReturn uint8_t
efx_bootcfg_csum(
Modified: head/sys/dev/sfxge/common/efx_types.h
==============================================================================
--- head/sys/dev/sfxge/common/efx_types.h Wed Dec 28 11:09:45 2016
(r310691)
+++ head/sys/dev/sfxge/common/efx_types.h Wed Dec 28 11:11:15 2016
(r310692)
@@ -264,37 +264,37 @@ typedef union efx_oword_u {
#if EFSYS_IS_BIG_ENDIAN
-#define __CPU_TO_LE_16(_x) (uint16_t)__SWAP16(_x)
-#define __LE_TO_CPU_16(_x) (uint16_t)__SWAP16(_x)
-#define __CPU_TO_BE_16(_x) (uint16_t)__NOSWAP16(_x)
-#define __BE_TO_CPU_16(_x) (uint16_t)__NOSWAP16(_x)
-
-#define __CPU_TO_LE_32(_x) (uint32_t)__SWAP32(_x)
-#define __LE_TO_CPU_32(_x) (uint32_t)__SWAP32(_x)
-#define __CPU_TO_BE_32(_x) (uint32_t)__NOSWAP32(_x)
-#define __BE_TO_CPU_32(_x) (uint32_t)__NOSWAP32(_x)
-
-#define __CPU_TO_LE_64(_x) (uint64_t)__SWAP64(_x)
-#define __LE_TO_CPU_64(_x) (uint64_t)__SWAP64(_x)
-#define __CPU_TO_BE_64(_x) (uint64_t)__NOSWAP64(_x)
-#define __BE_TO_CPU_64(_x) (uint64_t)__NOSWAP64(_x)
+#define __CPU_TO_LE_16(_x) ((uint16_t)__SWAP16(_x))
+#define __LE_TO_CPU_16(_x) ((uint16_t)__SWAP16(_x))
+#define __CPU_TO_BE_16(_x) ((uint16_t)__NOSWAP16(_x))
+#define __BE_TO_CPU_16(_x) ((uint16_t)__NOSWAP16(_x))
+
+#define __CPU_TO_LE_32(_x) ((uint32_t)__SWAP32(_x))
+#define __LE_TO_CPU_32(_x) ((uint32_t)__SWAP32(_x))
+#define __CPU_TO_BE_32(_x) ((uint32_t)__NOSWAP32(_x))
+#define __BE_TO_CPU_32(_x) ((uint32_t)__NOSWAP32(_x))
+
+#define __CPU_TO_LE_64(_x) ((uint64_t)__SWAP64(_x))
+#define __LE_TO_CPU_64(_x) ((uint64_t)__SWAP64(_x))
+#define __CPU_TO_BE_64(_x) ((uint64_t)__NOSWAP64(_x))
+#define __BE_TO_CPU_64(_x) ((uint64_t)__NOSWAP64(_x))
#elif EFSYS_IS_LITTLE_ENDIAN
-#define __CPU_TO_LE_16(_x) (uint16_t)__NOSWAP16(_x)
-#define __LE_TO_CPU_16(_x) (uint16_t)__NOSWAP16(_x)
-#define __CPU_TO_BE_16(_x) (uint16_t)__SWAP16(_x)
-#define __BE_TO_CPU_16(_x) (uint16_t)__SWAP16(_x)
-
-#define __CPU_TO_LE_32(_x) (uint32_t)__NOSWAP32(_x)
-#define __LE_TO_CPU_32(_x) (uint32_t)__NOSWAP32(_x)
-#define __CPU_TO_BE_32(_x) (uint32_t)__SWAP32(_x)
-#define __BE_TO_CPU_32(_x) (uint32_t)__SWAP32(_x)
-
-#define __CPU_TO_LE_64(_x) (uint64_t)__NOSWAP64(_x)
-#define __LE_TO_CPU_64(_x) (uint64_t)__NOSWAP64(_x)
-#define __CPU_TO_BE_64(_x) (uint64_t)__SWAP64(_x)
-#define __BE_TO_CPU_64(_x) (uint64_t)__SWAP64(_x)
+#define __CPU_TO_LE_16(_x) ((uint16_t)__NOSWAP16(_x))
+#define __LE_TO_CPU_16(_x) ((uint16_t)__NOSWAP16(_x))
+#define __CPU_TO_BE_16(_x) ((uint16_t)__SWAP16(_x))
+#define __BE_TO_CPU_16(_x) ((uint16_t)__SWAP16(_x))
+
+#define __CPU_TO_LE_32(_x) ((uint32_t)__NOSWAP32(_x))
+#define __LE_TO_CPU_32(_x) ((uint32_t)__NOSWAP32(_x))
+#define __CPU_TO_BE_32(_x) ((uint32_t)__SWAP32(_x))
+#define __BE_TO_CPU_32(_x) ((uint32_t)__SWAP32(_x))
+
+#define __CPU_TO_LE_64(_x) ((uint64_t)__NOSWAP64(_x))
+#define __LE_TO_CPU_64(_x) ((uint64_t)__NOSWAP64(_x))
+#define __CPU_TO_BE_64(_x) ((uint64_t)__SWAP64(_x))
+#define __BE_TO_CPU_64(_x) ((uint64_t)__SWAP64(_x))
#else
Modified: head/sys/dev/sfxge/common/mcdi_mon.c
==============================================================================
--- head/sys/dev/sfxge/common/mcdi_mon.c Wed Dec 28 11:09:45 2016
(r310691)
+++ head/sys/dev/sfxge/common/mcdi_mon.c Wed Dec 28 11:11:15 2016
(r310692)
@@ -38,8 +38,8 @@ __FBSDID("$FreeBSD$");
#if EFSYS_OPT_MON_STATS
-#define MCDI_MON_NEXT_PAGE (uint16_t)0xfffe
-#define MCDI_MON_INVALID_SENSOR (uint16_t)0xfffd
+#define MCDI_MON_NEXT_PAGE ((uint16_t)0xfffe)
+#define MCDI_MON_INVALID_SENSOR ((uint16_t)0xfffd)
#define MCDI_MON_PAGE_SIZE 0x20
/* Bitmasks of valid port(s) for each sensor */
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
