Sounds good. Thanks for the explanation! On Tue, Dec 27, 2016 at 10:48:17AM -0800, Adrian Chadd wrote: > Hi, > > As it's a kernel change in a frequently changing subsystem in -HEAD, > I'm opting not to bump it until I get the 11ac bits "done" enough. > Otherwise there'd be a lot of churn. I did bump it for the userland > facing ABI though as that did have a pretty big impact. > > Anyone using binary-only wifi kernel modules on FreeBSD should know better. :) > > I promise to bump it once 11ac is "done" enough to use, so there is a > good reference point. > > Thanks, > > > -adrian > > > On 27 December 2016 at 06:08, Shawn Webb <shawn.w...@hardenedbsd.org> wrote: > > On Tue, Dec 27, 2016 at 06:10:28AM +0000, Adrian Chadd wrote: > >> Author: adrian > >> Date: Tue Dec 27 06:10:28 2016 > >> New Revision: 310624 > >> URL: https://svnweb.freebsd.org/changeset/base/310624 > >> > >> Log: > >> [net80211] turn the default TX key configuration (for WEP) into a vap > >> callback. > >> > >> The ath10k firmware supports hardware WEP offload, and in native wifi > >> mode > >> (or 802.3 ethernet mode, for that matter) the WEP key isn't actually > >> included > >> in the TX payload from net80211. Instead, a separate firmware command > >> is issued > >> that sets the default TX key to be the specified key. > >> > >> However, net80211 doesn't at all inform the driver layer that this is > >> occuring - it just "expects" to be inserting WEP header information > >> when doing WEP TX, even with hardware encryption. > >> > >> So, to better support the newer world order, turn the default TX key > >> assignment > >> into a VAP method that can be overridden by the driver and ensure its > >> wrapped > >> in a crypto begin/end set. That way it should be correctly atomic from > >> the > >> point of view of keychanges (as long as the driver does the right thing.) > >> > >> It'd be nice if we passed through to the key_set call a flag that says > >> "also make this the default key" - that's captured here by calling the > >> deftxkey method after the key_set method. Maybe I can do that later. > >> > >> Note: this is a net80211 ABI change, and will require a kernel+modules > >> recompile. Happy Holidays, etc. > > > > Hey Adrian, > > > > Thank you very much for your hard work on the wireless stack. Since this > > introduces an ABI change, should __FreeBSD_version be bumped? > > > > Thanks, > > > > -- > > Shawn Webb > > Cofounder and Security Engineer > > HardenedBSD > > > > GPG Key ID: 0x6A84658F52456EEE > > GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE
-- Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE
signature.asc
Description: PGP signature
