On 12/10/16 at 09:35P, Oliver Pinter wrote: > On 10/21/16, Hiren Panchasara <hi...@freebsd.org> wrote: > > Author: hiren > > Date: Fri Oct 21 18:27:30 2016 > > New Revision: 307745 > > URL: https://svnweb.freebsd.org/changeset/base/307745 > > > > Log: > > Rework r306337. > > > > In sendit(), if mp->msg_control is present, then in sockargs() we are > > allocating mbuf to store mp->msg_control. Later in kern_sendit(), call > > to getsock_cap(), will check validity of file pointer passed, if this > > fails EBADF is returned but mbuf allocated in sockargs() is not freed. > > Made code changes to free the same. > > > > Since freeing control mbuf in sendit() after checking (control != NULL) > > may lead to double freeing of control mbuf in sendit(), we can free > > control mbuf in kern_sendit() if there are any errors in the routine. > > > > Submitted by: Lohith Bellad <lohith.bel...@me.com> > > Reviewed by: glebius > > MFC after: 3 weeks > > Differential Revision: https://reviews.freebsd.org/D8152 > > Hi Hiren! > > What's the status of the MFC? I not see them (this and r306337) in > 11-STABLE nor in 10-STABLE branch.
Thanks for the reminder. I MFCd to 11. I don't really track 10 anymore so I'd request you to do it yourself. If you can't for some reason, let me know. Cheers, Hiren
pgpSvDnrGKVF3.pgp
Description: PGP signature
